renepay: Support for BOLT12 #7985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lagrang3
force-pushed
the
renepay-bolt12
branch
6 times, most recently
from
5668dfc to
94be50d
Compare
Lagrang3
force-pushed
the
renepay-bolt12
branch
8 times, most recently
from
081bfeb to
895652e
Compare
Lagrang3
force-pushed
the
renepay-bolt12
branch
from
895652e to
8147933
Compare
Contributor
|
Rebasing on master... |
A first step towards supporting bolt12 invoices and blinded paths. Changelog-None Signed-off-by: Lagrang3 <[email protected]>
Enable routing through blinded paths using fake channels in local gossmods. Changelog-None Signed-off-by: Lagrang3 <[email protected]>
Add an rpc to renepay that is similar to sendpay that handles BOLT11 and BOLT12 payments. This is not the most elegant solution but it is a workaround until we implement it into lightningd which has more development friction. Changelog-None. Signed-off-by: Lagrang3 <[email protected]>
Changing route.amount to route.amount_deliver for clarity. This variable hold the value that the route delivers to destination. Changelog-None Signed-off-by: Lagrang3 <[email protected]>
Use renesendpay to send the payment allowing to pay to BOLT12 invoices from a higher level interface. Changelog-Add: renepay: Add support for BOLT12 payments Signed-off-by: Lagrang3 <[email protected]>
Fix error handling since we moved from sendpay to sendonion rpc. With sendonion once a route fails we don't get the scid and node_id that failed along the route, so we have to deduce those from our own internal data. Changelog-None Signed-off-by: Lagrang3 <[email protected]>
sendonion RPC does not allow to set the total amount in lightningd's wallet, therefore it mixing sendpay and sendonion payment parts would not work. That means for the time being we cannot complete a payment initialized with sendpay until we add a total_amount parameter to sendonion. Changelog-None. Signed-off-by: Lagrang3 <[email protected]>
Changelog-None. Signed-off-by: Lagrang3 <[email protected]>
Refactor create_onion function, now we could use the same function to build onions for sendonion and injectpaymentonion. Changelog-None. Signed-off-by: Lagrang3 <[email protected]>
Changelog-None. Signed-off-by: Lagrang3 <[email protected]>
Collect the shared secrets when making a payment request. We would need this if we use injectpaymentonion instead of sendonion. Changelog-None. Signed-off-by: Lagrang3 <[email protected]>
Changelog-None. Signed-off-by: Lagrang3 <[email protected]>
Changelog-None. Signed-off-by: Lagrang3 <[email protected]>
Changelog-None. Signed-off-by: Lagrang3 <[email protected]>
Changelog-None. Signed-off-by: Lagrang3 <[email protected]>
Use injectpaymentonion for payments with |routes|=0, ie. self-payments and blinded paths where our node is the first node in the blinded path. Changelog-None. Signed-off-by: Lagrang3 <[email protected]>
Always use a fake destination node, the self-payments are no longer a corner case for the routing problem in this way. Also it is ok for get_routes to return routes with zero length. Changelog-None. Signed-off-by: Lagrang3 <[email protected]>
When paying with injectpaymentonion we need to manually decode the error from the onion. Changelog-None. Signed-off-by: Lagrang3 <[email protected]>
Changelog-None. Signed-off-by: Lagrang3 <[email protected]>
rustyrussell
force-pushed
the
renepay-bolt12
branch
from
ee2f711 to
0b81024
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for BOLT12 in renepay.
Closes #6609
We compute routes to blinded paths by using a fake node as destination and then linking the entry point of every blinded path to the destination with a fake channel that represents the use of that blinded path. The same way that xpay does.
To send the payment we had to change from sendpay to sendonion. We could have used injectpaymentonion but since the injectpaymentonion does not yet support passing
shared_secretsnor thedestinationid we preferred sendonion, also sendonion is more in tune with renepay design of sending the onions and wait for responses in a notification as opposed to xpay that reacts as soon as injectpaymentonion returns with success or failure.